Add 3DVar and error covariance toolbox (dirac test) main programs. #106
Conversation
interpolator adding.
…t to state method. Update yaml 3DVar yaml file so 3DVar runs through (but produces nans currently).
* Update ci container * allow manual trigger of ci * temporary change to force ci to run * revert temporary change as ci now gets past cmake config step
|
OK! I am just going to fiddle with the tags so that the ci container is associated with your branch. Its just admin, but it might mean that the ci wont work on this branch for an hour or two. |
|
I'd like to put this forward for review. It's the basic implementation of orca-jedi assimilation. It's still very simple with no spatial covariances. Still it's a bit of a milestone. The main code changes are to add 3DVar and error covariance toolbox (Dirac) executables and associated yaml files to run new ctests of these executables. In the case of 3DVar the tests assimilates a set of idealised observations. I added a few more methods which were needed for 3DVar. There a couple of methods added for interpolating from obs locations to model fields and vice versa. All of these new methods have new unit tests added. The bbb tests all succeeded (http://fcm1/cylc-review/taskjobs/frld/?suite=mo-bundle-orca-jedi-3dvar). There are 6 tests still running as I write this. |
Back in business and the CI test worked. Thanks! |
Confirmed all bbb tasks pass. One task ctest_jjtests_dirac_b_C192__spice_gnu_debug ran out wallclock first time but succeeded on retriggering. |
There was a problem hiding this comment.
Its looking great!
I have a few thoughts, particularly in the interpolator. I also am struggling to get an interactive build right now (I seem to have borked my setup) Hopefully I will be able to run and explore the tests tomorrow. I am a bit unclear on how the dirac test works, aside from checking that the configuration can run at all? Is there any way we can check against a test reference?
Thanks Toby. It looks like I can commit your suggestions so I'll give them all a go and report back. On the Dirac executable test it just tests that it runs at the moment. I think you have some H(x) tests that check against reference data I'll have a go at copying this approach in my dirac and 3dvar tests. |
Co-authored-by: Toby Searle <[email protected]>
…etOffice/orca-jedi into feature/add_simple_dirac_3dvar
creation of json schema again for 3dvar and errorcovariancetoolbox applications.
Thanks! Yes please do merge. |
Description
This PR adds 3DVar assimilation and error covariance toolbox main programs along with a very basic tests with no background error correlations.
See #88 for the original plan for the implementation of assimilation in orca-jedi. Modified plan after this PR
Issue(s) addressed
N/A
Dependencies
List the other PRs that this PR is dependent on:
Impact
Expected impact on downstream repositories or workflows:
None
Checklist